GAWB-4026: Initial simple cost calculation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qi77Qi
reviewed
Jan 18, 2019
core/src/main/scala/org/broadinstitute/workbench/ccm/JsonCodec.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/broadinstitute/workbench/ccm/pricing/GcpPricing.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/broadinstitute/workbench/ccm/pricing/GcpPricing.scala
Outdated
Show resolved
Hide resolved
| 0.010931) | ||
| assertEquals(r, expectedResponse) | ||
| } | ||
| res.fold[Unit](e => throw e, identity) |
There was a problem hiding this comment.
you should be able to do res == Right(xx)
Qi77Qi
reviewed
Jan 18, 2019
core/src/main/scala/org/broadinstitute/workbench/ccm/model.scala
Outdated
Show resolved
Hide resolved
dvoet
reviewed
Jan 24, 2019
|
|
||
| private def getPriceOfCall(call: Call, priceList: PriceList, startTime: Instant, endTime: Instant): Either[String, Double] = { | ||
| for { | ||
| _ <- if (call.status.asString == "Success") Right(()) else Left(s"Call {name} status was ${call.status.asString}.") // not evaluating workflows that are in flight or Failed or Aborted or whatever |
There was a problem hiding this comment.
why are we not evaluating aborted or failed? They cost money too.
There was a problem hiding this comment.
Yes! I meant to change that to evaluating all terminal statuses, not just successes
|
|
||
|
|
||
| final case class RuntimeAttributes(cpuNumber: CpuNumber, | ||
| disks: Disks, |
There was a problem hiding this comment.
I'm actually not sure, I will ask Cromwell people
There was a problem hiding this comment.
The answer is yes, I'll turn it into a list
| } | ||
|
|
||
| private def getCallDuration(call: Call, cromwellStartTime: Instant, cromwellEndTime: Instant): Long = { | ||
| // ToDo: add option to ignore preempted calls and just return 0 |
There was a problem hiding this comment.
Oh - this comment was some vestige of a thing we aren't doing anymore (I think earlier we were just going to make the calculation ignore preemptibility for an initial iteration). I'll remove the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's missing: