Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't touch disk when handling zipped imports #4648

Closed
aednichols opened this issue Feb 14, 2019 · 1 comment
Closed

Don't touch disk when handling zipped imports #4648

aednichols opened this issue Feb 14, 2019 · 1 comment

Comments

@aednichols
Copy link
Collaborator

aednichols commented Feb 14, 2019

In #4406, we added a cleanup routine that deletes unzipped imports when we're done with them.

It would be nice to handle imports without touching the disk at all - see this branch for a mostly-working implementation

That implementation is 99% complete but seems to suffer from a Scala bug in certain packaging/deployment configurations - such as the one used in Travis!

@aednichols
Copy link
Collaborator Author

Because eliminating zip imports entirely is another "some day" goal, there is a world where we never even want to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants