Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing config options to aws tutorial #4378

Merged
merged 2 commits into from
Nov 19, 2018

Conversation

wleepang
Copy link
Contributor

addresses #4278

@geoffjentry
Copy link
Contributor

geoffjentry commented Nov 11, 2018

👍

Approved with PullApprove

Copy link
Contributor

@cjllanwarne cjllanwarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, otherwise LGTM

Replace `<s3-bucket-name>`in the configuration file with the appropriate bucket name.
Replace in the configuration file:

* `<your-region` with the region where your resources are launched (e.g. "us-east-1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a closing > on <your-region>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@cjllanwarne cjllanwarne merged commit 59434a2 into broadinstitute:develop Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants