Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: AWS Batch with CWL: did not localize cwl.inputs.json [BA-4586] #5057

Conversation

Kirvolque
Copy link

The purpose of this PR is to fix issue #4586.
It turns out that Cromwell looks for the ad hoc files in the wrong location, while using AWS. These files placed in the S3 bucket, while Cromwell expects them to be in the root execution directory.
Therefore, we have changed the place where Cromwell searches that files. We also added an integration test that reproduces the problem.

@gemmalam gemmalam added the Community Contribution A pull request from the Cromwell open-source community label Jul 8, 2019
@gemmalam gemmalam changed the title Fix: AWS Batch with CWL: did not localize cwl.inputs.json Fix: AWS Batch with CWL: did not localize cwl.inputs.json [BA-5796] Jul 8, 2019
@gemmalam gemmalam requested a review from cjllanwarne July 8, 2019 14:36
@Kirvolque Kirvolque force-pushed the EPMLSTRCMW-2_IT_and_fix_with_directiry_path_cnahge branch from 8fbd678 to f7fd7af Compare July 8, 2019 19:59
@gemmalam gemmalam changed the title Fix: AWS Batch with CWL: did not localize cwl.inputs.json [BA-5796] Fix: AWS Batch with CWL: did not localize cwl.inputs.json [BA-4586] Jul 9, 2019
@geoffjentry
Copy link
Contributor

Hi @Kirvolque - in talking to @myazinn it sounds like he's on the right track to the solution here. Closing this - feel free to reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A pull request from the Cromwell open-source community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants