Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WX-1531] Struct Literal Type Checking #7402

Merged
merged 13 commits into from
Apr 10, 2024
Merged

[WX-1531] Struct Literal Type Checking #7402

merged 13 commits into from
Apr 10, 2024

Conversation

THWiseman
Copy link
Contributor

@THWiseman THWiseman commented Apr 9, 2024 •
edited

  • Refactor things slightly to give the typeEvaluators access to the typeAliases map, which contains all the struct definitions
  • Make a typeEvaluator for StructLiterals

@THWiseman THWiseman marked this pull request as ready for review April 9, 2024 19:07
@THWiseman THWiseman requested a review from a team as a code owner April 9, 2024 19:07
aednichols
aednichols approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm liking the partition-enhanced version of structLiteralTypeEvaluator. If we think of anything even more clever we can always fancify it later.

jgainerdewar
jgainerdewar reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@jgainerdewar jgainerdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Hope you found a way to get IntelliJ to update all those method calls for you.

...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Outdated Show resolved Hide resolved
...e/src/main/scala/wdl/transforms/base/linking/expression/types/EngineFunctionEvaluators.scala Outdated Show resolved Hide resolved
...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Outdated Show resolved Hide resolved
...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Outdated Show resolved Hide resolved
...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Show resolved Hide resolved
...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Show resolved Hide resolved
...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Outdated Show resolved Hide resolved
...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Outdated Show resolved Hide resolved
...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Outdated Show resolved Hide resolved
...src/main/scala/wdl/transforms/biscayne/linking/expression/types/BiscayneTypeEvaluators.scala Show resolved Hide resolved
jgainerdewar
jgainerdewar approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@jgainerdewar jgainerdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types: ✔️

@THWiseman THWiseman merged commit 3201eb6 into develop Apr 10, 2024
35 checks passed
@THWiseman THWiseman deleted the WX-1531-c branch April 10, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aednichols aednichols aednichols approved these changes

@jgainerdewar jgainerdewar jgainerdewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@THWiseman @aednichols @jgainerdewar