WX-1595 Remove genomics usage from GCP Batch #7411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Batch backend configuration depends on entries prefixed by "genomics" which is the wrong term, this entry has been renamed to "batch-api". Also, the usages for these configs were renamed to "batch". At last, there was an usage involving lifesciences which has been removed too. NOTE: This is a breaking change, existing projecs using batch backend will need to update their configuration.
AlexITC
changed the title
AlexITC
changed the title
AlexITC
commented
Apr 24, 2024
| // Credentials object for the Genomics API | ||
| private lazy val genomicsCredentials: Future[Credentials] = gcpBatchConfiguration.batchAttributes.auths.genomics | ||
| // Credentials object for the Batch API | ||
| private lazy val batchCredentials: Future[Credentials] = gcpBatchConfiguration.batchAttributes.auths.batch | ||
| .retryCredentials(workflowOptions, | ||
| List( | ||
| CloudLifeSciencesScopes.CLOUD_PLATFORM, |
There was a problem hiding this comment.
I have tried removing this (CloudLifeSciencesScopes.CLOUD_PLATFORM ) and GenomicsScopes.GENOMICS but centaur tests failed.
Does anyone know whether we should use a different scope? I'd expect that we shouldn't need anything lifesciences/genomics related (see https://github.com/broadinstitute/cromwell/actions/runs/8815748415/job/24198334692).
AlexITC
changed the title
AlexITC
changed the title
aednichols
changed the title
aednichols
requested changes
May 14, 2024
| | genomics { | ||
| | // A reference to an auth defined in the `google` stanza at the top. This auth is used to create | ||
| | // Pipelines and manipulate auth JSONs. | ||
| | batch { |
There was a problem hiding this comment.
I'd personally prefer we use batch everywhere for consistency.
Seems easier to get right, especially when transitioning from a product we just called genomics.
|
@aednichols the comments are resolved and tests are passing, thanks. |
aednichols
approved these changes
May 14, 2024
rsaperst
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Batch backend configuration depends on entries prefixed by "genomics" which is the wrong term, this entry has been renamed to "batch-api".
Also, the usages for these configs were renamed to "batch".
At last, there was an usage involving lifesciences which has been removed too.
NOTE: This is a breaking change, existing projecs using batch backend will need to update their configuration.