WX-1595 GCP Batch cleanup #7428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AlexITC
commented
May 10, 2024
AlexITC
commented
- GcpBatchAsyncBackendJobExecutionActor -> pollBackOff had maxInterval value hardcoded instead of using the config entry.
- GcpBatchTestConfig was still referencing papi instead of batch.
- Rename PipelinesApiEmptyMountedDisk to BatchApiEmptyMountedDisk.
- GcpBatchAsyncBackendJobExecutionActorSpec was still referencing pipelines instead of batch.
- Localization was referencing papi instead of batch.
- RunnableUtils had unused definitions which are now deleted.
- GcpBatchAsyncBackendJobExecutionActor -> pollBackOff had maxInterval value hardcoded instead of using the config entry. - GcpBatchTestConfig was still referencing papi instead of batch. - Rename PipelinesApiEmptyMountedDisk to BatchApiEmptyMountedDisk. - GcpBatchAsyncBackendJobExecutionActorSpec was still referencing pipelines instead of batch. - Localization was referencing papi instead of batch. - RunnableUtils had unused definitions which are now deleted.
aednichols
approved these changes
May 14, 2024
rsaperst
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.