Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1627 Belated addition of v87 changelog entries #7436

Merged
merged 6 commits into from
May 16, 2024

Conversation

jgainerdewar
Copy link
Contributor

@jgainerdewar jgainerdewar commented May 15, 2024

@jgainerdewar jgainerdewar requested a review from a team as a code owner May 15, 2024 15:21
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
jgainerdewar and others added 3 commits May 15, 2024 11:39
Co-authored-by: Adam Nichols <anichols@broadinstitute.org>
Co-authored-by: Adam Nichols <anichols@broadinstitute.org>
Co-authored-by: Adam Nichols <anichols@broadinstitute.org>
Copy link
Contributor

@rsaperst rsaperst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be a good idea to mention #7414 since it introduced a configurable field to users? Maybe something like "Added configuration option to remove 4 byte UTF-8 encoded characters (e.g. emojis) from metadata strings with the given key(s)"?

@jgainerdewar
Copy link
Contributor Author

@rsaperst Excellent call-out, I did not include that here because the important bug-fix to that feature did not make it in to v87.

Copy link
Contributor

@rsaperst rsaperst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgainerdewar Got it, in that case this looks good to me!

@jgainerdewar jgainerdewar merged commit f111395 into develop May 16, 2024
30 checks passed
@jgainerdewar jgainerdewar deleted the jgd_WX-1627_releasenotes branch May 16, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants