Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS-542: Use gh actions for unit tests [risk: low] #818

Merged
merged 7 commits into from
Nov 25, 2020

Conversation

davidangb
Copy link
Contributor

@davidangb davidangb commented Nov 23, 2020

Use GH Actions for unit tests instead of Travis.

Because the GH Actions -> Coveralls integration for sbt is weak (see for instance https://github.com/lemurheavy/coveralls-public, issue 1388), this PR also:

  • switches from scoverage to sbt/sbt-jacoco to generate coverage reports
  • switches from coveralls to codecov as our hosted coverage service

Note that the Travis checks for this PR will fail, because I've removed the .travis.yml; this is expected until we disable Travis for this repo. Once this PR is approved, I'll change which checks are required for PRs.


Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

@coveralls
Copy link

coveralls commented Nov 23, 2020

Coverage Status

Coverage remained the same at 64.359% when pulling 362a41e on da_unitTestActions into 080afb6 on develop.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@080afb6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #818   +/-   ##
=========================================
  Coverage           ?   0.00%           
=========================================
  Files              ?     115           
  Lines              ?    3263           
  Branches           ?     510           
=========================================
  Hits               ?       0           
  Misses             ?    3263           
  Partials           ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080afb6...67597e7. Read the comment docs.

@davidangb davidangb marked this pull request as ready for review November 24, 2020 18:19
before_cache:
- rm -fv $HOME/.ivy2/.sbt.ivy.lock
- find $HOME/.ivy2/cache -name "ivydata-*.properties" -print -delete
- find $HOME/.sbt -name "*.lock" -print -delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's nice we don't need these steps anymore!

@ansingh7115
Copy link
Contributor

Will the "Missing base commit" error be automatically fixed when this is merged - is it just because this is the first time we're using it that we're getting this error?

Copy link
Contributor

@ansingh7115 ansingh7115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests run as they should on GitHub Actions

@davidangb
Copy link
Contributor Author

@ansingh7115 yup, I expect that the "missing base commit" error from codecov will be fixed after this merges and we start to upload ongoing coverage reports to them. If it remains a problem, we'll fix it!

@davidangb davidangb changed the title first attempt: use gh actions for unit tests [no ticket; risk: low] Use gh actions for unit tests [no ticket; risk: low] Nov 25, 2020
@davidangb davidangb merged commit 85c4dfa into develop Nov 25, 2020
@davidangb davidangb deleted the da_unitTestActions branch November 25, 2020 14:12
@davidangb davidangb changed the title Use gh actions for unit tests [no ticket; risk: low] AS-542: Use gh actions for unit tests [risk: low] Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants