-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AS-542: Use gh actions for unit tests [risk: low] #818
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #818 +/- ##
=========================================
Coverage ? 0.00%
=========================================
Files ? 115
Lines ? 3263
Branches ? 510
=========================================
Hits ? 0
Misses ? 3263
Partials ? 0 Continue to review full report at Codecov.
|
before_cache: | ||
- rm -fv $HOME/.ivy2/.sbt.ivy.lock | ||
- find $HOME/.ivy2/cache -name "ivydata-*.properties" -print -delete | ||
- find $HOME/.sbt -name "*.lock" -print -delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's nice we don't need these steps anymore!
Will the "Missing base commit" error be automatically fixed when this is merged - is it just because this is the first time we're using it that we're getting this error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the tests run as they should on GitHub Actions
@ansingh7115 yup, I expect that the "missing base commit" error from codecov will be fixed after this merges and we start to upload ongoing coverage reports to them. If it remains a problem, we'll fix it! |
Use GH Actions for unit tests instead of Travis.
Because the GH Actions -> Coveralls integration for sbt is weak (see for instance https://github.com/lemurheavy/coveralls-public, issue 1388), this PR also:
scoverage
tosbt/sbt-jacoco
to generate coverage reportsNote that the Travis checks for this PR will fail, because I've removed the .travis.yml; this is expected until we disable Travis for this repo. Once this PR is approved, I'll change which checks are required for PRs.
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:
In all cases: