fix code coverage [AJ-509]

[davidangb]

Code coverage was pretty broken. This repo has been at 0% coverage for … as long as codecov has been tracking PRs: https://app.codecov.io/gh/broadinstitute/firecloud-orchestration/pulls. This may go all the way back to #818 .

If nobody noticed or cared that coverage was broken, it begs the question: should we even have code coverage? I'm keeping it in place for now because it doesn't add too much overhead.

Coverage generation

switch from sbt-jacoco to sbt-scoverage. JaCoCo was consistently generating 0% coverage and I couldn't figure out why. We use scoverage elsewhere (e.g. Rawls) so I just switched.

Codecov uploading

Bonus fix rom https://github.com/codecov/codecov-action:

As of February 1, 2022, v1 has been fully sunset and no longer functions

Which doesn't seem to be true; the v1 action was succeeding at uploading our 0% coverage reports. Nonetheless, let's update to their recommended version.

[codecov]

Codecov Report

Merging #971 (2ee3cb9) into develop (5e4fe10) will increase coverage by 68.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #971       +/-   ##
============================================
+ Coverage     0.00%   68.26%   +68.26%     
============================================
  Files          112      102       -10     
  Lines         3149     3539      +390     
  Branches       484      111      -373     
============================================
+ Hits             0     2416     +2416     
+ Misses        3149     1123     -2026     

Impacted Files	Coverage Δ
...scala/org/broadinstitute/dsde/firecloud/Boot.scala	0.00% <0.00%> (ø)
.../broadinstitute/dsde/firecloud/model/Project.scala	0.00% <0.00%> (ø)
...stitute/dsde/firecloud/dataaccess/HttpSamDAO.scala	0.00% <0.00%> (ø)
...itute/dsde/firecloud/dataaccess/HttpAgoraDAO.scala	0.00% <0.00%> (ø)
...itute/dsde/firecloud/dataaccess/HttpRawlsDAO.scala	0.00% <0.00%> (ø)
...ute/dsde/firecloud/dataaccess/HttpConsentDAO.scala	0.00% <0.00%> (ø)
...ute/dsde/firecloud/dataaccess/HttpThurloeDAO.scala	0.00% <0.00%> (ø)
...te/dsde/firecloud/webservice/OauthApiService.scala	0.00% <0.00%> (ø)
...e/dsde/firecloud/dataaccess/ElasticSearchDAO.scala	0.00% <0.00%> (ø)
...e/dsde/firecloud/dataaccess/ImportServiceDAO.scala	0.00% <0.00%> (ø)
... and 102 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e4fe10...2ee3cb9. Read the comment docs.