Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the FireCloud Status page in the footer [GAWB-3351] #1272

Merged
3 commits merged into from
Apr 23, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2018

  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
  • Submitter: If you changed a URL that is used elsewhere (e.g. in an email), comment about where it is used and ensure the dependent code is updated.
  • Submitter: JIRA ticket checks:
    • Acceptance criteria exists and is met
    • Note any changes to implementation from the description
    • To Demo flag is set
    • Release Summary is filled out, if applicable
    • Add notes on how to QA
  • Submitter: Update RC_XXX release ticket with any config or environment changes necessary
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them
  • Submitter: If you're adding new automated UI tests, review the test plan with QA
  • Review cycle:
    • LR reviews
    • Rest of team may comment on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH
    • Submitter updates documentation as needed
    • Submitter reassigns to LR for further feedback
  • TL sign off
  • LR sign off
  • Product Owner sign off
  • Submitter: Verify all tests go green, including CI tests and automated UI tests.
  • Submitter: Squash commits and merge to develop. If adding test code, merge application code and test code at the same time.
  • Submitter: Delete branch after merge
  • Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

@ghost ghost changed the title Added a link to the FireCloud Status page in the footer [GAWB-3351] Add a link to the FireCloud Status page in the footer [GAWB-3351] Apr 10, 2018
@aweng98
Copy link
Contributor

aweng98 commented Apr 10, 2018

Is this async-loading UI object that may causes page to move when finished rendering on page? If so, I'm concerned it causes UI automation tests to become flaky.

@@ -239,7 +239,7 @@
"FireCloud service is temporarily unavailable.")]
(notifications/render-alert {:title title
:message msg
:link "http://status.firecloud.org/"
:link (config/status-url)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aweng98 are you referring to this change specifically? Please let me know, I'm happy to revert if the alternative might cause flakiness.

@ghost
Copy link
Author

ghost commented Apr 11, 2018

jenkins retest

@ghost ghost requested a review from jmthibault79 April 13, 2018 13:29
@jmthibault79
Copy link
Contributor

jmthibault79 commented Apr 17, 2018

@jbuabbud Should probably close this until the new version based on https://github.com/broadinstitute/firecloud-develop/pull/1102 is ready - so we're not reviewing outdated code

@ghost
Copy link
Author

ghost commented Apr 17, 2018

Closing until broadinstitute/firecloud-develop#1102 merges.

@ghost ghost closed this Apr 17, 2018
@ghost ghost reopened this Apr 17, 2018
Copy link
Contributor

@jmthibault79 jmthibault79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally: no status link and no rendering errors.

Locally with a manual update to config.json adding a statusUrl: Status link is present with my value.

@ghost ghost merged commit fc8ffb5 into develop Apr 23, 2018
@ghost ghost deleted the jb_GAWB-3351 branch June 14, 2018 15:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants