cromwell metadata params [risk: low] #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
changed the title
MattPutnam
approved these changes
Nov 14, 2018
| @@ -140,7 +141,7 @@ | |||
| (set (keys query-parameters))) | |||
| (str "Malformed query parameters: " query-parameters)) | |||
| {:path (str "/workspaces/" (id-path workspace-id) "/entityQuery/" type "?" | |||
| (clojure.string/join "&" (keep (fn [[k v]] | |||
| (string/join "&" (keep (fn [[k v]] | |||
| (some->> v str not-empty (str k "="))) | |||
| query-parameters))) | |||
| (links/create-internal {:onClick #(swap! state update :expanded? not)} | ||
| (if expanded? "Hide" "Show"))) | ||
| ;; use expanded? to show/hide the WorkflowTimingDiagram component via the DOM | ||
| [:div {:myattr "whereami" :style {:display (if expanded? "block" "none")}} |
There was a problem hiding this comment.
hahaha yes thank you for the catch.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataBiosphere/firecloud-app#213
DataBiosphere/firecloud-app#214
when making requests to the Cromwell workflow metadata API (via orch and rawls), specify only those
includeKeyvalues the UI needs. This hint allows Cromwell to do only the work that's truly necessary, and keeps the response sizes smaller by eliminating cruft.additionally, don't load the data needed to power the timing diagram when first viewing a workflow's details, since the timing diagram is collapsed by default. Once the user clicks to expand the timing diagram, make a second ajax call to get the data it needs. This keeps the initial page much smaller and only gets timing data when absolutely necessary.