This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Sam: add tests to the public API #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following tests: * unclipped start and stop * copy constructor tests * copy assignment test * tags of types char, int and double * char_tag when tag is not a char * string_tag when tag is not a string * is_missing support for tags major strides towards addressing issue #4
|
@droazen can you take a peek ? |
| // check integer, char and float tags | ||
| const auto read1_za_tag = read1.double_tag("ZA"); | ||
| BOOST_CHECK_EQUAL(read1_za_tag.name(), "ZA"); | ||
| BOOST_CHECK(read1_za_tag.value() >= 2.3 - 0.001 && read1_za_tag.value() <= 2.3 + 0.001); |
There was a problem hiding this comment.
float comparison with a tolerance should be a utility function
There was a problem hiding this comment.
my laziness... BOOST_CHECK_CLOSE is for that exactly.
|
Review complete |
|
@droazen I'll rebase and merge at your command, sir. |
|
Looks good now -- merge away |
droazen
added a commit
that referenced
this pull request
Jul 10, 2014
Sam: add tests to the public API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following tests:
major strides towards addressing issue #4