This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
When deep copying Sam/Variant records, do not also deep copy the header #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deep copying the headers every time a record is copied is wasteful and unnecessary, given that headers are immutable (with the single exception of VariantHeader::advanced_merge_header(), which should be moved to a builder)
|
Improved doxygen docs as Mauricio suggested -- should be ready to merge once Travis passes |
MauricioCarneiro
pushed a commit
that referenced
this pull request
Jul 17, 2014
…ying When deep copying Sam/Variant records, do not also deep copy the header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deep copying the headers every time a record is copied is wasteful and
unnecessary, given that headers are immutable (with the single exception
of VariantHeader::advanced_merge_header(), which should be moved to a
builder)