Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated Pandas append operation for log analysis #699

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

kjaisingh
Copy link
Collaborator

analyze_monitoring_logs2.py currently uses the append operation of Pandas, though this has been deprecated since Pandas 1.4.0.

Updates this reference to instead use Pandas' new concat operator.

Copy link
Collaborator

@epiercehoffman epiercehoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, go ahead and merge!

I tested this and it is compatible with earlier versions of pandas (tested 1.0.5) and the grouped.tsv output was identical to the previous version of the script.

@kjaisingh kjaisingh merged commit ce91122 into main Jul 29, 2024
5 checks passed
@kjaisingh kjaisingh deleted the kj_cloud_training branch July 29, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants