Fixed model parameter assignment typo in gCNV ploidy model #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelklee
approved these changes
Nov 26, 2019
|
Hmm, perhaps we should consider an additional PR to either set the default value to give the old behavior (i.e., equal to the ‘psi_j_scale’ default) or change all defaults for all parameters to whatever we are using now. Either way, we should mention in the release notes that models may need to be refit @mwalker174. |
|
Definitely should inform users to refit their models in the release notes. I think we should discuss changes to parameter defaults in our next meeting. |
|
Maybe we can bump gcnvkernel version, which will check the model version in CASE mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samuelklee Could you review please?