Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions of htsjdk/picard/disq #6637

Merged
merged 1 commit into from Jun 4, 2020
Merged

Update versions of htsjdk/picard/disq #6637

merged 1 commit into from Jun 4, 2020

Conversation

lbergelson
Copy link
Member

  • This includes major improvements to the cram code.
  • htsjdk 2.21.2 -> 2.22.0
  • picard 2.21.9 -> 2.22.8
  • disq 0.3.5 -> 0.3.6
  • spark 2.4.3 -> 2.4.5

@lbergelson
Update versions of htsjdk/picard/disq
9e4a121 
* This includes major improvements to the cram code.
* htsjdk 2.21.2 -> 2.22.0
* picard 2.21.9 -> 2.22.8
* disq 0.3.5 -> 0.3.6
* spark 2.4.3 -> 2.4.5
@lbergelson
Copy link
Member Author

@jamesemery Should be an easy review I hope...

jamesemery
jamesemery approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@jamesemery jamesemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include the fix for SortSamSpark in disq? If so should we reenable that test we disabled?

@lbergelson
Copy link
Member Author

@jamesemery This does not include the fix. That's still ongoing.

@lbergelson
Copy link
Member Author

We'll need another disq bump, but I want to get the htsjdk changes in for RevertSamSpark.

@lbergelson lbergelson merged commit 33648a6 into master Jun 4, 2020
@lbergelson lbergelson deleted the lb_test_htsjdk branch June 4, 2020 17:14
jonn-smith pushed a commit that referenced this pull request Jul 14, 2020
@lbergelson @jonn-smith
Update versions of htsjdk/picard/disq (#6637)
e15ef0c 
* This includes major improvements to the cram code.
* htsjdk 2.21.2 -> 2.22.0
* picard 2.21.9 -> 2.22.8
* disq 0.3.5 -> 0.3.6
* spark 2.4.3 -> 2.4.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesemery jamesemery jamesemery approved these changes

Assignees

@jamesemery jamesemery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lbergelson @jamesemery