-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in all the work from the long-term Special Project Malaria branch #440
Conversation
wdl/pipelines/TechAgnostic/TertiaryAnalysis/ProcessMalariaBarcodesDemo.wdl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why are the set of pipelines in a folder called "Z_One_Off_Analyses" not integrated with the rest of the pipeline folder?
- In some of the wdls I've commented to move the description to the meta block of the workflow, this is so the wdl doc page on the repository site is formated correctly. The automated documentation is sensitive to hashes at the top of the page.
wdl/pipelines/TechAgnostic/TertiaryAnalysis/PanelProcessMalariaBarcodesForRh.wdl
Outdated
Show resolved
Hide resolved
wdl/pipelines/TechAgnostic/TertiaryAnalysis/ExpandedDrugResistanceMarkerExtraction.wdl
Show resolved
Hide resolved
wdl/pipelines/TechAgnostic/TertiaryAnalysis/ExpandedDrugResistanceMarkerAggregation.wdl
Show resolved
Hide resolved
@@ -137,8 +137,8 @@ task RemovePalindromes { | |||
|
|||
runtime { | |||
cpu: default_attr.cpu_cores | |||
memory: default_attr.mem_gb + " GiB" | |||
disks: "local-disk " + default_attr.disk_gb + " HDD" | |||
memory: select_first([default_attr.mem_gb]) + " GiB" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are deprecated wdls being updated, are they used by any wdls in the main pipeline folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this so that miniwdl check
would pass. I was running it on all wdls in the repo before I remembered that the deprecated
folder was not being checked. It's not being used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I follow the same logic as Jonn.
That is, I validate locally too, including the deprecate
d ones. So if any of my changes makes the deprecated ones invalid, I'd do the minimal to make them valid but nothing more.
That being said, I don't fix bugs in those deprecated pipelines or tasks.
wdl/pipelines/TechAgnostic/VariantCalling/SRJointCallGVCFsWithGenomicsDB.wdl
Outdated
Show resolved
Hide resolved
wdl/pipelines/Z_One_Off_Analyses/SRJointCallGVCFsWithGenomicsDB_Pf_Niare_VETS.wdl
Outdated
Show resolved
Hide resolved
wdl/pipelines/Z_One_Off_Analyses/SRWholeGenome_Pf_Niare_VETS.wdl
Outdated
Show resolved
Hide resolved
@bshifaw The workflows and tasks in the |
Co-authored-by: bshifaw <bshifaw@broadinstitute.org>
Co-authored-by: bshifaw <bshifaw@broadinstitute.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the commented description lines at the top from wdl/pipelines/TechAgnostic/Utility/BenchmarkVCFs.wdl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merging in the long-running branch Kiran and I created for the malaria work.
I have attempted to put everything in reasonable places.
I know this is big, but I'm hoping to merge this fast so I can make a few updates to these pipelines on top of this branch.