Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional LiftoverVcf tests #1011

Merged
merged 1 commit into from Dec 15, 2017
Merged

Add additional LiftoverVcf tests #1011

merged 1 commit into from Dec 15, 2017

Conversation

bbimber
Copy link
Contributor

@bbimber bbimber commented Dec 5, 2017

Description

In #947 I refactored LiftOverVcf to improve performance. This just adds more test coverage, specifically around lifting symbolic and no-call alleles. I also changed a couple variables within the test DataSources to be static constants so they could be shared across tests.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@coveralls
Copy link

coveralls commented Dec 5, 2017

Coverage Status

Coverage increased (+0.01%) to 77.23% when pulling 5c66187 on bbimber:LiftoverTests into b0b9f78 on broadinstitute:master.

@bbimber
Copy link
Contributor Author

bbimber commented Dec 5, 2017

@yfarjoun: this is related to #947. All i'm doing in this PR is adding more test coverage. I originally opened a PR for this in Nov, and just noticed other changes on master caused conflicts in my original PR. Would it be possible to get this approved and merged sooner to avoid that hassle again? I would not ask, except this is such a minor change.

@yfarjoun
Copy link
Contributor

Thanks for the extra tests. and sorry for the delay.

@yfarjoun
Copy link
Contributor

👍

@yfarjoun yfarjoun merged commit 70da387 into broadinstitute:master Dec 15, 2017
@bbimber bbimber deleted the LiftoverTests branch April 1, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants