Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more SD inputs to LiftoverIntervals and BedToIntervalList #1446

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

yfarjoun
Copy link
Contributor

@yfarjoun yfarjoun commented Jan 2, 2020

Description

Give your PR a concise yet descriptive title
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@yfarjoun yfarjoun changed the title Yf allow more sd inputs to liftover intervals Allow more SD inputs to LiftoverIntervals and BedToIntervalList Jan 2, 2020
jessicaway
jessicaway previously approved these changes Jan 27, 2020
src/main/java/picard/util/BedToIntervalList.java Outdated Show resolved Hide resolved
src/main/java/picard/util/BedToIntervalList.java Outdated Show resolved Hide resolved
@yfarjoun
Copy link
Contributor Author

yfarjoun commented Feb 10, 2020

Thanks @jessicaway I accepted your edits. please re-review

@yfarjoun yfarjoun force-pushed the yf_allow_more_SD_inputs_to_LIFTOVER_INTERVALS branch from e55530b to eaa2f2c Compare February 10, 2020 20:08
@yfarjoun yfarjoun merged commit 9c99c33 into master Apr 3, 2020
@yfarjoun yfarjoun deleted the yf_allow_more_SD_inputs_to_LIFTOVER_INTERVALS branch April 3, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants