GL-853 Modify VcfToAdpc to handle multiple samples. #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbggrant
force-pushed
the
gg_GL-853_HaveVcfToAdpcHandleMultiSampleVcfs
branch
from
1101a79
to
a229b85
Compare
gbggrant
changed the title
|
retest this please |
jessicaway
reviewed
Feb 25, 2020
jessicaway
reviewed
Feb 25, 2020
jessicaway
approved these changes
Feb 25, 2020
Put NaN in the adc.bin file if normalized intensity is null. Output files containing number of samples and markers (useful for running VerifyIDIntensity itself). Added tests
gbggrant
force-pushed
the
gg_GL-853_HaveVcfToAdpcHandleMultiSampleVcfs
branch
from
f3fccea
to
53834b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify VcfToAdpc to handle multiple samples.
Put NaN in the adc.bin file if normalized intensity is null.
Output files containing number of samples and markers (useful for running VerifyIDIntensity itself).
Added tests
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests