Added a public accessor for the per-target coverage information. #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yfarjoun
reviewed
Oct 17, 2016
| @@ -406,6 +399,11 @@ public void setBaitSetName(final String name) { | |||
| this.metrics.PROBE_SET = name; | |||
| } | |||
|
|
|||
| /** Returns the accumulated coverage per target. */ | |||
| public Map<Interval,Coverage> getCoverageByTarget() { | |||
There was a problem hiding this comment.
-Space after comma,
-Note that the map is still mutable since it may change "from within" due to another call to acceptRecord. Could you add a comment to that effect?
otherwise, 👍
|
Done @yfarjoun - will merge one tests go green again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find that I'm using the
HsMetricCollectorand related classes programmatically a lot, and it would be really nice to be able to access the per-base and per-target coverage information that is accumulated without having to write it out to a file and parse it back in again. This PR adds a one-line accessor to make the information available to other classes.