Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make column names in ExtractIlluminaBarcodes public #957

Merged
merged 1 commit into from Oct 20, 2017
Merged

Make column names in ExtractIlluminaBarcodes public #957

merged 1 commit into from Oct 20, 2017

Conversation

magicDGS
Copy link
Contributor

@magicDGS magicDGS commented Oct 16, 2017

Description

The column header names in ExtractIlluminaBarcodes are private constants that cannot be used to check if a file has this header names programmatically. This PR makes them public to allow re-usage for similar kind of data.

In addition, this constants are added to the documentation annotations to avoid possible inconsistencies with the actual value.


Checklist (never delete this)

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

@coveralls
Copy link

coveralls commented Oct 16, 2017

Coverage Status

Coverage remained the same at 76.894% when pulling 75b8701 on magicDGS:dgs_ExtractIlluminaBarcodes_column_constants into fd16f8a on broadinstitute:master.

@yfarjoun
Copy link
Contributor

👍

@yfarjoun yfarjoun merged commit 1294637 into broadinstitute:master Oct 20, 2017
@magicDGS
Copy link
Contributor Author

Thanks @yfarjoun!

@magicDGS magicDGS deleted the dgs_ExtractIlluminaBarcodes_column_constants branch October 20, 2017 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants