Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds usage statement to UmiAwareMarkDuplicatesWithMateCigar that it shouldn't be used with RNAseq or other technologies with long gaps. #959

Merged
merged 2 commits into from Oct 20, 2017

Conversation

fleharty
Copy link
Contributor

Description

This adds a usage statement to UmiAwareMarkDuplicatesWithMateCigar that informs the user that this tool should not be used with RNAseq, or other sequencing technologies that have large alignment gaps. Addressing issue #953


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on Travis

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage remained the same at 77.055% when pulling bfb1224 on mf_umiUsageStatement into 4a846f3 on master.

@fleharty
Copy link
Contributor Author

Waiting for some issues to be resolved from #953 before I make this pull request again.

@fleharty fleharty closed this Oct 18, 2017
@fleharty fleharty reopened this Oct 18, 2017
@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage remained the same at 77.055% when pulling bfb1224 on mf_umiUsageStatement into 4a846f3 on master.

@fleharty fleharty merged commit 3904528 into master Oct 20, 2017
@fleharty fleharty deleted the mf_umiUsageStatement branch October 20, 2017 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants