-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert site_full
back to site
#45
Comments
Will we stick with nomenclature that |
We need to determine The issue specifically is that, in #23, we updated a column name from A side note that is beyond scope of this issue, is that I am noticing quite a lot of bleed through between non-core config entries in the two config files. I think streamlining these config files (maybe worth revisiting some of the decisions in #5). For example, I think we can solve the |
I think we should definitely stick to Currently, what do we use the parsed |
this is still where the weld is broken, working through it now
In fb8eb0a I made an executive decision to do as proposed in #45 (comment) in c8bbaaa i attempt to fix this in the qc step. This is still broken - will fix asap |
in d98ded3 is a somewhat fragile fix... It works with the current setup, but we really need to create a much improved config system in version 0.2. I believe that an enhanced config system will deal with these inconsistencies automatically and "for free". This fragile fix should be revisited. |
In #23 (specifically #23 (comment)) I suggested a column name change within the
0.preprocess
recipe module. This was a bad idea!It was a bad idea b/c it breaks
0.merge-single-cells.py
at: https://github.com/broadinstitute/pooled-cell-painting-profiling-recipe/blob/1be45bb33e1da71050dbb102352690cf8a08fb7c/1.generate-profiles/0.merge-single-cells.py#L143L146we need to revert this change (and address some corresponding breaks after updating) before we can produce profiles.
The text was updated successfully, but these errors were encountered: