-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating paths before first weld #43
Conversation
eventually this file will go into the template repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't really fit with the theme of this PR, but since it touches print() statements it made me think, it would be nice to have a print() at the end of every step saying it's done.
0./1. and 0./2. already end with print("All sites complete.")
but something like print("Step 0./0. processing complete.")
would be nice to have at the end of other steps.
Awesome - agree with your suggestion (see #46 )
We really need to get some testing done in this repo 😖 I am thinking that I can address #45 here, if we can solve it quickly (should be a super quick fix once we settle on nomenclature) |
this is still where the weld is broken, working through it now
Prepare for a landmark pull request merge! This PR represents the bulk of the remaining fixes to welding version 0.1 🎉 |
The recipe will be called as a submodule in the template repo. This pull request ensures that a call to
bash weld.sh
will call the versioned controlled recipe scripts.An important note here is that after this is merged, testing with the recipe as we have in the past will no longer work.
A second important note is that the
config_utils.py
file will eventually be moved to the template (this way all the config related files are kept in one place). This is the current thinking right now at least.