This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Add tests, content instead of source logic, and ensure support #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
coreone
commented
Sep 2, 2016
•
coreone
commented
- Add .rspec for better test output
- Add the ability to pass certificate/key data in as "content"
- Add "ensure" to certs::site so that we can remove certs/keys as well
- Fix bug with service notification code
- Add beginning spec tests for certs::site
- Fix cert/key source issue, and add placeholder to site spec
- Add the ability to add chain or ca by content
- Add SPEC tests for ca/chain files
- Add SPEC tests for merging certificate with chain/ca
- Add lots more tests
|
|
||
| if $cert_chain { | ||
| file { "${_chain_path}/${chain}": | ||
| ensure => $ensure, |
There was a problem hiding this comment.
I didn't add the absent piece for CA/chain because I don't know what would happen if you have more than one site defined. If one site has ensure present, and another has ensure absent, which would win for the CA/chain files?
rcalixte
force-pushed
the
tex_testing
branch
from
a3c7692
to
06e7bae
Compare
* Add the ability to pass certificate/key data in as "content" * Add "ensure" to certs::site so that we can remove certs/keys as well * Fix bug with service notification code * Add beginning spec tests for certs::site * Fix cert/key source issue, and add placeholder to site spec * Add the ability to add chain or ca by content * Add SPEC tests for ca/chain files * Add SPEC tests for merging certificate with chain/ca * Add lots more tests
rcalixte
force-pushed
the
tex_testing
branch
from
06e7bae
to
9186211
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.