Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully enable subworkflow response time test for fc-app 97 #961

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

jmthibault79
Copy link
Contributor

@jmthibault79 jmthibault79 commented Jul 12, 2018

For DataBiosphere/firecloud-app#97
Made possible by https://github.com/broadinstitute/firecloud-develop/pull/1261

  • Submitter: Include the JIRA issue number in the PR description
  • Submitter: Check that the Product Owner has signed off on any user-facing changes
  • Submitter: Make sure Swagger is updated if API changes
    • ...and Orchestration's Swagger too!
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
  • Submitter: JIRA ticket checks:
    • Acceptance criteria exists and is met
    • Note any changes to implementation from the description
    • To Demo flag is set
    • Release Summary is filled out, if applicable
    • Add notes on how to QA
  • Submitter: Update RC_XXX release ticket with any config or environment changes necessary
  • Submitter: Database checks:
    • If PR includes new or changed db queries, include the explain plans in the description
    • Make sure liquibase is updated if appropriate
    • If doing a migration, take a backup of the
      dev
      and
      alpha
      DBs in Google Cloud Console
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Tell your tech lead (TL) that the PR exists if they want to look at it
  • Anoint a lead reviewer (LR). Assign PR to LR
  • Review cycle:
    • LR reviews
    • Rest of team may comment on PR at will
    • LR assigns to submitter for feedback fixes
    • Submitter rebases to develop again if necessary
    • Submitter makes further commits. DO NOT SQUASH
    • Submitter updates documentation as needed
    • Submitter reassigns to LR for further feedback
  • TL sign off
  • LR sign off
  • Assign to submitter to finalize
  • Submitter: Verify all tests go green, including CI tests
  • Submitter: Squash commits and merge to develop
  • Submitter: Delete branch after merge
  • Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
  • Submitter: Verify swagger UI on dev environment still works after deployment
  • Submitter: Inform other teams of any API changes via Slack and/or email
  • Submitter: Mark JIRA issue as resolved once this checklist is completed

@jmthibault79 jmthibault79 requested review from a user and gdlex4015 July 12, 2018 17:37
@jmthibault79
Copy link
Contributor Author

Unrelated DataSpec errors in test run: https://fc-jenkins.dsp-techops.broadinstitute.org/job/swatomation-pipeline/7677/

Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aweng98 aweng98 self-requested a review July 13, 2018 14:53
@jmthibault79 jmthibault79 merged commit 1f1ea19 into develop Jul 13, 2018
@jmthibault79 jmthibault79 deleted the jt_sub_wf_test branch July 13, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants