Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully enable subworkflow response time test for fc-app 97 #961

Merged
merged 1 commit into from
Jul 13, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class RawlsApiSpec extends TestKit(ActorSystem("MySpec")) with FreeSpecLike with
"should retrieve metadata with widely scattered sub-workflows in a short time" in {
implicit val token: AuthToken = studentAToken

val scatterWidth = 300
val scatterWidth = 500

// this will run scatterCount^levels workflows, so be careful if increasing these values!
val topLevelMethod: Method = methodTree(levels = 2, scatterCount = scatterWidth)
Expand Down Expand Up @@ -285,9 +285,7 @@ class RawlsApiSpec extends TestKit(ActorSystem("MySpec")) with FreeSpecLike with

// can we also quickly retrieve metadata for a few of the subworkflows?

// NOT YET. Known issue in this iteration of firecloud-app#97
// TODO: uncomment when the real solution is in place
//Random.shuffle(subworkflowIds.take(4)).foreach { cromwellMetadata(_) }
Random.shuffle(subworkflowIds.take(10)).foreach { cromwellMetadata(_) }

// clean up: Abort and wait for one minute or Aborted, whichever comes first
// Timeout is OK here: just make a best effort
Expand Down