Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate googleSubjectId with current uid #198

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Conversation

Qi77Qi
Copy link
Contributor

@Qi77Qi Qi77Qi commented Aug 31, 2018

After this, we should run migration, so that there won't be users missing googleSubjectId field before we change proxy

Discussion https://broadinstitute.slack.com/archives/CC528F8JX/p1535681551000100

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

@Qi77Qi Qi77Qi mentioned this pull request Aug 31, 2018
4 tasks
Copy link
Contributor

@gpolumbo-broad gpolumbo-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it even though it doesn't make sense to me that the sn, cn also have the same value as the uid and googleSubjectId.

@Qi77Qi
Copy link
Contributor Author

Qi77Qi commented Sep 4, 2018

@gpolumbo-broad , I don't know much about sn and cn, but I think we should leave them as is for this PR.

The reason for duplicating googleSubjectId here is just so we can change proxy to lookup users by googleSubjectId. Code change in this PR will be updated in #190, but this PR allows us to change proxy without breaking anything in the mean time. It's 2 in https://broadinstitute.atlassian.net/wiki/spaces/~952052303/pages/622624856/sam+Support+invite+feature

@Qi77Qi Qi77Qi merged commit 95d8286 into develop Sep 4, 2018
@Qi77Qi Qi77Qi deleted the justGoogleSubjectId branch September 4, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants