Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PF-504] Remove workspace editor role, give its permissions to writers #515

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

zloery
Copy link
Contributor

@zloery zloery commented Mar 11, 2021

Ticket: PF-504

This ticket removes the recently added editor role from workspace objects and instead grants its permissions around child resources to the writer role. This is more in line with existing Rawls behavior, and will simplify future migrations. In the future, we may add an additional workspace role for "modifying objects without creating or deleting", which was previously the writer role.

I've intentionally left the editor role in all four controlled resource definitions. It's different than the workspace editor role, and separating delete permission from read/write permission is core to our model of private resources.


PR checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.54% when pulling df1fa4c on wsm-editor into d730e23 on develop.

Copy link
Contributor

@ddietterich ddietterich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ddietterich ddietterich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zloery zloery merged commit 157f011 into develop Mar 15, 2021
@zloery zloery deleted the wsm-editor branch March 15, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants