Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-1624] Rename covid -> staged #580

Merged
merged 6 commits into from
Feb 23, 2022

Conversation

okotsopoulos
Copy link
Contributor

@okotsopoulos okotsopoulos commented Feb 18, 2022

Purpose

The first application of generic staged workload architecture was COVID sequencing in Terra. Naming in our code and public-facing documentation reflected this.

Changes

  • Renaming in code: covid -> staged
  • Renaming (and a little bit of rewriting and reorganizing) in docs: covid -> staged

System Tests

Passed:

wm111-e35:wfl okotsopo$ make TARGET=system
export CPCACHE=/Users/okotsopo/wfl/api/.cpcache;            \
	export WFL_WFL_URL=http://localhost:3000; \
	clojure  -M:parallel-test wfl.system.v1-endpoint-test | \
	tee /Users/okotsopo/wfl/derived/api/system.log
WARNING: Specified path is external to project: ../derived/api/src
WARNING: Specified path is external to project: ../derived/api/resources

Ran 33 tests containing 374 assertions.
0 failures, 0 errors.
api system finished on Tue Feb 22 16:55:28 EST 2022
docs system finished on Tue Feb 22 16:55:28 EST 2022
functions/aou system finished on Tue Feb 22 16:55:28 EST 2022
functions/sg system finished on Tue Feb 22 16:55:28 EST 2022
helm system finished on Tue Feb 22 16:55:28 EST 2022
ui system finished on Tue Feb 22 16:55:28 EST 2022

Review Instructions

If you wish, you could spin up a local docsite to review the docsite changes. I did this to confirm formatting and that links worked.

okotsopoulos and others added 5 commits February 18, 2022 16:18
Most places where we refer to COVID workloads, we are dealing in generic staged workloads with other applications.
* Update reitit.
* Reduce cleverness.
* Expose the logging_level API.
* Add logging_level endpoints.
* Fix bug in level-string? ... jeez.
* Add logging_level endpoint test.
* clojure -M:format` in this directory.
* Respond to OK's comments.
@okotsopoulos okotsopoulos marked this pull request as ready for review February 22, 2022 22:12
api/src/wfl/api/handlers.clj Outdated Show resolved Hide resolved
api/src/wfl/module/batch.clj Show resolved Hide resolved
docs/md/staged-workload.md Outdated Show resolved Hide resolved
@okotsopoulos okotsopoulos merged commit 232cf80 into develop Feb 23, 2022
@okotsopoulos okotsopoulos deleted the okotsopo/GH-1624-covid-rename-to-staged branch February 23, 2022 17:40
okotsopoulos added a commit that referenced this pull request Mar 4, 2022
GH-1629 TerraExecutor gets method configuration version from Firecloud (#585)
GH-1553 GH-1604 Add error handling to Slack service (#584)
GH-1628 Look at the first 7 workloads returned in test-workflows-by-filters. (#583)
GH-1617 Consistent workload representation for logs (#579)
GH-1624 Rename covid -> staged in code, docs (#580)
okotsopoulos added a commit that referenced this pull request Mar 7, 2022
GH-1629 TerraExecutor gets method configuration version from Firecloud (#585)
GH-1553 GH-1604 Add error handling to Slack service (#584)
GH-1628 Look at the first 7 workloads returned in test-workflows-by-filters. (#583)
GH-1617 Consistent workload representation for logs (#579)
GH-1624 Rename covid -> staged in code, docs (#580)
okotsopoulos added a commit that referenced this pull request Mar 7, 2022
GH-1629 TerraExecutor gets method configuration version from Firecloud (#585)
GH-1553 GH-1604 Add error handling to Slack service (#584)
GH-1628 Look at the first 7 workloads returned in test-workflows-by-filters. (#583)
GH-1617 Consistent workload representation for logs (#579)
GH-1624 Rename covid -> staged in code, docs (#580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants