Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.28.1 is already being brought in transitively. Forcing it explicitly so that we don't have multiple versions.
Bumping firestore dependency as well because it's bringing in grpc 1.12.0, which is causing some issue if we were using this in google2 as dependency in ammonite. This shouldn't cause any breaking change for caller of
GoogleFirestoreService
. Within the library usage of firestore lib, there's one deprecation, which shouldn't be an issue since we set it totrue
previously.cc @dvoet
PR checklist
If you're doing a major or minor version bump to any libraries:
project/Settings.scala
createVersion()
CHANGELOG.md
for those libraries@deprecated
instead of deleting code where possibleIn all cases:
README.md
and theCHANGELOG.md
for any libs you changed withTRAVIS-REPLACE-ME
to auto-update the version string