add the ability to ignore absolute paths from watcher #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has no effect.
This adds an option to mark certain absolute paths as ignored by the watcher. The motivation here is that if you want to be able to rebuild arbitrary node packages (which can put their source code at the top level of their project if they want to), and those packages emit build artifacts into some of their own subdirectories (like `dist` as used by ember-cli), you end up watching your own output. In this situation, it is straightforward to know which path(s) are your own output, and tell broccoli not to watch them. `sane`'s `ignored` option is perfect for this, except that it's always relative to the watchedDir, so broccoli's Watcher must translate.
ef4
added a commit
to ember-cli/ember-cli
that referenced
this pull request
Dec 2, 2020
Embroider v2 packages can put their source code wherever they want to (as they are "just regular node packages"). That means when we're interactively rebuilding them, we need to watch their root. But if a v2 addon contains its own test suite, and that test suite emits a `dist` folder, we will end up watching our own output, and cause an infinite build loop. This fixes that by always ignoring the build's own output directory. This depends on broccolijs/broccoli#474 and will be updated to stop pointing at my fork once we have a broccoli release.
This was referenced Dec 2, 2020
|
FYI - Just landed #473, doesn't seem like this needs a rebase though. |
ef4
added a commit
to embroider-build/ember-cli
that referenced
this pull request
Dec 7, 2020
Embroider v2 packages can put their source code wherever they want to (as they are "just regular node packages"). That means when we're interactively rebuilding them, we need to watch their root. But if a v2 addon contains its own test suite, and that test suite emits a `dist` folder, we will end up watching our own output, and cause an infinite build loop. This fixes that by always ignoring the build's own output directory. This depends on broccolijs/broccoli#474 and will be updated to stop pointing at my fork once we have a broccoli release.
ef4
added a commit
to ember-cli/ember-cli
that referenced
this pull request
Dec 7, 2020
Embroider v2 packages can put their source code wherever they want to (as they are "just regular node packages"). That means when we're interactively rebuilding them, we need to watch their root. But if a v2 addon contains its own test suite, and that test suite emits a `dist` folder, we will end up watching our own output, and cause an infinite build loop. This fixes that by always ignoring the build's own output directory. This depends on broccolijs/broccoli#474 and will be updated to stop pointing at my fork once we have a broccoli release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR builds off #473, for a smaller review see only 5fda57e.)
This adds an option to mark certain absolute paths as ignored by the watcher.
The motivation here is that if you want to be able to rebuild arbitrary node packages (which can put their source code at the top level of their project if they want to), and those packages emit build artifacts into some of their own subdirectories (like
distas used by ember-cli), you end up watching your own output.In this situation, it is straightforward to know which path(s) are your own output, and tell broccoli not to watch them.
sane'signoredoption is perfect for this, except that it's always relative to the watchedDir, so broccoli's Watcher must translate.