Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RStudio Viewer Window When Available Instead of Browser #51

Closed
brodieG opened this issue Aug 1, 2016 · 4 comments
Closed

Use RStudio Viewer Window When Available Instead of Browser #51

brodieG opened this issue Aug 1, 2016 · 4 comments
Milestone

Comments

@brodieG
Copy link
Owner

brodieG commented Aug 1, 2016

As per Noam Ross.

@brodieG brodieG added this to the 0.1.3 milestone Aug 1, 2016
@timelyportfolio
Copy link

timelyportfolio commented Aug 1, 2016

I'll be happy to help here. Would it be ok to add htmltools dependency? diffobj already requires rmarkdown which requires htmltools so guessing it if fine. Then you could replace html.R using htmltools `tags which easily plug into RStudio.

@brodieG
Copy link
Owner Author

brodieG commented Aug 1, 2016

My initial inclination is to avoid doing so. The markdown dependency is a suggests as opposed to an imports. I'm not completely opposed, but would want to first believe that doing the integration without htmltools is difficult. In the little research I did it seemed straightforward.

I'm trying to keep the import dependency list small. Right now the only non-base dependency is crayon, and I submitted a PR to crayon to remove dependencies that it had that were not strictly necessary.

If you are willing to address this without htmltools then by all means. I started working on it a little bit so I can push the branch for you. Otherwise you can wait for me to bang my head on this a bit and see how it goes.

@brodieG
Copy link
Owner Author

brodieG commented Aug 1, 2016

Actually, the basic implementation was super easy. It's working already. Need to think about how to handle the inset vs. maximized sizes though since the standard small screen of the viewer is no good with the default width settings.

@brodieG
Copy link
Owner Author

brodieG commented Aug 1, 2016

The viewer branch has output go to the RStudio viewer. I haven't tested much at all though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants