Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues with blank source or only comments #21

Open
brodycj opened this issue Jan 24, 2023 · 0 comments
Open

issues with blank source or only comments #21

brodycj opened this issue Jan 24, 2023 · 0 comments
Assignees
@brodycj
Labels
bug Something isn't working

Comments

@brodycj
Copy link
Owner

brodycj commented Jan 24, 2023 •
edited
Loading

(updated)

While investigating #17 further I have discovered some issues if the code is blank or has only comments.

I added some tests in fd305a4. I discovered a case where it started reporting an internal error rather than "No content" from Webpack, introduced in commit 03f414a in patch release v0.13.3.

I have improved the error reporting in this case with a temporary workaround solution in 79a2ac5.

May need to investigate how Webpack would handle this kind of input in real life.
@brodycj brodycj added the bug Something isn't working label Jan 24, 2023
@brodycj brodycj self-assigned this Jan 24, 2023
@brodycj brodycj mentioned this issue Jan 24, 2023
Open
brodycj added a commit that referenced this issue Jan 24, 2023
@brodycj
test: test with comments only in the input
e1b109f 
NOTE that the exception output message had changed since v0.13.2.

ref:

- #21
brodycj added a commit that referenced this issue Jan 24, 2023
@brodycj
test: test with blank & comments only in the input
fd305a4 
NOTE that the exception output message had changed since v0.13.2.

ref:

- #21
brodycj added a commit that referenced this issue Jan 24, 2023
@brodycj
fix: improve some Terser & Webpack error reporting
79a2ac5 
- show result with error info from Terser if needed
- show informative message instead of an internal error
  in case there is no code for Webpack to process
  (temporary workaround solution)

ref: #21
@brodycj brodycj changed the title issues with only comments issues with blank source or only comments Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brodycj brodycj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brodycj