Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligns requestAnimationFrame's callback to the w3c specification #2455

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

uazo
Copy link
Collaborator

@uazo uazo commented Nov 18, 2022

Description

In the end, the google team took my changes as they are (and I am glad).
this is the temporary patch until we get there.

Fix for #2370

All submissions

  • there are no other open Pull Requests for the same update/change
  • Bromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

@csagan5
Copy link
Contributor

csagan5 commented Nov 18, 2022

In the end, the google team took my changes as they are (and I am glad).

That's great news! Will you also get some credits?

@uazo
Copy link
Collaborator Author

uazo commented Nov 19, 2022

Will you also get some credits?

obviously not... (but you know I don't care)
I would not have been able to create the tests they did, but I saw what they did and I will learn. I saw that there is even a (very complete) framework for blink-related tests, it may be useful to us

@csagan5 csagan5 merged commit 1a98943 into bromite:master Nov 19, 2022
@uazo uazo deleted the fix-webworker-requestanimationframe branch November 19, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants