Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fscalar to ks #31

Closed
thenetworkgrinch opened this issue Feb 24, 2023 · 2 comments
Closed

Change fscalar to ks #31

thenetworkgrinch opened this issue Feb 24, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@thenetworkgrinch
Copy link
Contributor

thenetworkgrinch commented Feb 24, 2023

fscalar in the JSON config is ks and following some normalized documentation should be preferred.

Deferring to @7910f6ba7ee4 since this is a major design change to a function used by them (and apparently all other falcon teams).

@7910f6ba7ee4
Copy link
Contributor

fscalar I think is not exactly ks (?) since it's a scalar being applied to an already existing configuration angleKv (since the feedforward when it gets to the angle motor has already been multiplied by this Kv).

I also may have found where the issues have originated, which might not require an fscalar anymore. The talons apparently have their feedforward in percentage, not volts. I'm currently now testing feedforward with it simply scaled down with the nominal voltage, and it seems to work well, I'll make an issue for it later.

@thenetworkgrinch
Copy link
Contributor Author

Feel free to commit the solution after testing!

@thenetworkgrinch thenetworkgrinch closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants