Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper macro to upload artifacts by command #45

Closed
djbelknapaw opened this issue Jul 30, 2021 · 3 comments
Closed

Wrapper macro to upload artifacts by command #45

djbelknapaw opened this issue Jul 30, 2021 · 3 comments

Comments

@djbelknapaw
Copy link

Right now users upload artifacts by specifying which artifacts to upload (manifest, catalog, etc.) That can be a pain to remember which artifacts to upload after which dbt command.

I'd be interested in seeing a wrapper macro so I could upload artifacts via:

dbt run-operation upload_dbt_artifacts_by_command --args '{command: run}'

This would just be a convenience feature that would map the command to the appropriate artifacts and run the existing macro to upload them. You could still upload specific artifacts using the existing macro.

I'm open to contributing if you're interested in adding this and don't want to spend the time on your end.

@NiallRees
Copy link
Contributor

Hey @djbelknapaw - this would be a valuable contribution! Please feel free to put a PR together.

@alanmcruickshank
Copy link
Contributor

I might pick this up along with the solution for #62 .

@NiallRees
Copy link
Contributor

We've been busy reimplementing the package, removing the use of artifacts altogether. The new version uses the graph and results context variables. We'd be grateful for any feedback on the first beta release: https://github.com/brooklyn-data/dbt_artifacts/releases/tag/1.0.0b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants