-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report websites where Browserpass doesn't work #62
Comments
Autosubmit doesn't work for: |
Discourse sites will unfortunately not work until they improve their markup, sadly they are not very interested in doing so: discourse/discourse#7056 |
https://ticket.coreboot.org/login |
esia.gosuslugi.ru works for me, make sure to test in the latest version 😉 |
I use СНИЛС login |
version 3.0.3 |
I don't have the right credentials so I can't really test a successful login, but I click on СНИЛС, fill it with random credentials and I see the "Войти" button becoming grey, something is refreshing, and then I get "wrong username or password" red error, so as far as I can tell auto-submit actually works? 😕 What do you see exactly? And what browser do you use? |
firefox 66.0.1-1, debian sid |
I have the same behavior for random СНИЛС and password, seems like I won't be able to reproduce because I don't have the correct credentials 😞 By the way, sadly there will be cases when autosubmit only works in Chromium but not in Firefox, because we have now an additional way of submitting forms, but Firefox doesn't support this (yet?): #55 It's still an improvement, because in v2 such forms didn't work in both Firefox and Chromium 🙂 |
can reproduce for random credentials:
for is not submitted, no red alert "Введено неверное имя пользователя или пароль" |
Fixed by #70 |
I tried My exact steps:
I do get a red alert about incorrect password. |
both firefox 66.0.1-1 and chromium 73.0.3683.75-1 with clean profiles are able to submit (get incorrect password error) with fake credentials that I specified, sorry. but both do not submit my real credentials |
Looks like I've found it, try this one:
|
This turned out to be a BEAUTIFUL discovery, a bug in a most unexpected location. Very happy that you gave me precise repro steps! Solved in #87 🙂 |
This is an interesting case @OkanEsen. The reason for this behavior is because Browserpass is trying to determine where a domain name is in the string @OkanEsen were the screenshots made on @erayd what do you think about teaching The severity is low as there is a simple workaround (hit Backspace, find |
Yes, that's correct and the default domain for a PiHole installation afaik. It's not a huge deal breaker for me, though I should mention, that there are other devices in my network, which are using non-standard domains too, such as Maybe it does make sense to extend the domain suggestion to non TLDs too, at least for the ones, which are specified inside a password file, such as |
I think it's also fairly common to host local servers on non-existent domains for local development, so I also tend to vote for doing this, unless anyone can think of any security issues with doing that. |
I think this is a good idea. It'll remember after the first use anyway, so it's not a big deal, but I think this will be a useful improvement to the first-use UX. |
newegg.ca doesn't work: |
Nice one, will be fixed by #110, thanks for reporting! |
Autosubmit doesn't work on my work's Identity Provider (PingID) with the new version. With the old (2.x) it did work. Tested both on Chrome and Firefox, on Mac. Autosubmit is switched on and works on other sites. It's hard to give a direct link as it's only meant to be called from another site. But if you go to https://spiceportal.se.com you should be redirected to it. You won't be able to get in, but you should be able to see the form. |
https://ebay-kleinanzeigen.de also has |
Thanks as usual 🙂 These two show similar behavior but I currently have no good ideas how they could be solved without breaking a lot of other websites, their markup violates our core assumption that if website developers know what a This one is so silly we can't support it, they change the field type on click via javascript, so until a user clicks on the field it is truly a non-interesting regular text field where passwords most certainly should not be inserted... 😄 |
https://bill.nevalink.net |
https://zadarma.com/en/ |
https://www.voip-info.org |
Password is filled, but username is not.
|
RouterOS router webfig login page It could be tested online: http://demo.mt.lv/webfig/ |
Thanks @532910. Will investigate why this is, as fill + enter does work, so it seems odd that autosubmit doesn't. As it happens, I use Browserpass to log in to RouterOS on a daily basis, and @maximbaz also has a router that runs it. So we don't need the online demo to test with. But I do appreciate that you linked it for us - thank you! |
@532910 I've investigated, and it seems the RouterOS webfig login page doesn't actually contain a form at all. The fields are simply input fields in a table, and the login button isn't actually a button at all, but merely a styled link with a javascript click handler attached to it. There's no way that Browserpass should ever be auto-submitting something like that sorry. However, autofill + pressing enter does work just fine. |
Thank you for investigation |
It seems that browserpass can't find the submit button in https://app.nalo.fr/components/auth/#/login. |
This is using Ver. 3.7.2 in Firefox 87.0 Filling a modal html form doesn't work for local addresses like It is easy to be deceived by the browser filling out the credentials from history. In order to reproduce, make sure to delete history for the server. |
Again, Ver. 3.7.2 in Firefox 87.0 First time only, I get a complaint window, saying "javascript application, form origin is supposed to be www.fido.ca (or www.airbnb.ca) but it is www.google.com. Then I say OK, and I get the ebove error. |
Doesn't work on: https://espacepro.cmb.fr/auth/login |
Thank you for posting these 👍
The case here is that markup is weird, the fields which Browserpass doesn't find are simply not passing sanity check. In the first case it's unidentifiable login button (we avoid pressing a random button after putting credentials on the page), in the latter two cases it's just bad markup, login fields are actually made invisible with CSS and what you see on the page is divs drawn to look as fields... So browserpass doesn't treat those invisible fields as a real login form. My best suggestion is to get those supported via #195
This I could not actually reproduce, or I misunderstood the issue. If I go to an IP address and it contains a html login form, and I have in my password store an entry called If it's a modal HTTP form (a popup that browser shows, which prevents you from interacting with browser until you submit or cancel this popup), make sure to look at this section of the docs, for example you must open such page from within Browserpass for it to be able to provide the credentials.
At the moment the root cause is #73, didn't research if their markup is good otherwise. |
EDIT: this is definitely a case for #74, custom selectors specified in pass entries. |
Trip Actions seems to do some non-standard stuff, at least I cannot get browserpass to fill in my details: https://app.tripactions.com/app/user2/auth |
@tomclark Home Assistant is really annoying for me. Any update? Home assistant has no "name" property in the input fields so I tried to add them but nothing changed. Where is the issue? |
ikea.com |
On |
On |
browserpass successfully fills username and password for openwrt's luci but doesn't automatically submit form after this |
On
|
Sites using Authentik (https://goauthentik.io/) don't work. |
GLS Onlinebanking is broken: Is there a way to add a Element to USERNAME_FIELDS in a variable per pass entry? so i can add user: and userfield: vrNetKey in my passstore... |
"vrNetKey" is also used by other German banks, e.g. Volksbank and Sparda-Bank: |
Instagram (see #323) |
On Error: Error: No fillable forms available for fields: login, secret |
On https://www.interrail.eu/en/login#/login, the username field (email) is filled in properly, but the password is ignored. I could not see any output from the extension on the developer console. Am I supposed to be looking somewhere else? |
Please use this thread to report websites where Browserpass doesn't fully work, e.g. Browserpass is unable to fill username or password, or fills wrong form, or autosubmit doesn't work.
I'm not promising to support every single website, but I will investigate every example and if possible improve the detection logic.
I will not however add special cases for certain websites, I don't want Browserpass become a collection of broken websites on the Internet 🙂
The text was updated successfully, but these errors were encountered: