-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minified versions cannot be consolidated to a single js file #46
Comments
Hey mate, Could you specify some more about the problem that's occurring and which files you're trying to bundle and what the error is. Thanks :) |
I'm using version 1.5. When I bundle the compressed versions of history.js and history.html4.js I get this error: Bundling the uncompressed versions are fine. I tried different combinations of bundles using history.js, history.html4.js, and history.adapter.jquery.js to see if I could narrow down which file was the problem, but every bundle I try results in error. I minified each of these 3 files using the above link and then bundled them into a single file and it works. |
You gotta ensure that there is a semi-colon at the end of each file. Otherwise, the two closures sit next to each other. |
oops, i should have seen that. thanks! |
Yeah. I have noticed that many minifiers, including Uglify, removes the trailing semi-colon at the end of a file. Google Closure keeps it intact. This removal is fine if the file is not being concatenated with other scripts. |
The compressed versions are weird. I used this minifier below and now I no longer get javascript errors when combining the various history.js files into a single history-all.js file.
http://refresh-sf.com/yui/
The text was updated successfully, but these errors were encountered: