-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all browsers that support web extensions #27
Comments
This is low priority IMO. First iron out all problems on the firefox platform and when browsh becomes popular, other people will adapt it for other platforms such as Chrome. |
It would be great if this supported Chrome. |
@msaffer I agree. But could you just give me your own reasons? Thanks. |
Just having acquired a Raspberry Pi 3 B+, I'd say the Chrome/Chromium support would be nice, as a version of firefox supported by Browsh is very hard to install on RPi3 due to an issue with armhf and the later versions of Firefox (https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1711337). |
+1 for chrome. Thanks. Chrome is the most popular. Even Microsoft has given up Edge/IE for chrome. |
Can't we use any headless browser and inject a content script to every rendered web page? |
In theory yes, but in reality there are some complicated hacks that make Browsh possible, like being able to screenshot the rendered page in order to detect the visibility of text. |
Almost every headless browser allows to make a screenshot and access the DOM. Can't we use e.g. Playwright with multiple engines? |
I was able to run Chromium (non-headless) with an extension using Next we could try loading a modified Browsh web extension using |
Oh! Thanks for checking that out. So the screenshot needs to be available in code like this: https://github.com/browsh-org/browsh/blob/2f713f40fc87f5a3ca1ba15c469844c61f5f3fc6/webext/src/dom/graphics_builder.js |
I can see you're using a deprecated Firefox-only |
It's been a long time since I checked the latest Firefox API, I think current Browsh is pinned to some really old version, like v67! |
Can we unpin it and use a standard way to capture a tab, so it works in both Firefox and Chromium? |
Sure, but we'd need to test that |
I also want to see this with chromium, webextension can be used, but I think that browsh should support Selenium WebDriver, using that can add more browsers. |
Also I found this selenium webdriver client, it is for go. Browsh can use nodejs, but that would add more dependency, so here is the client. I also found more dated webdriver clients. Or Playwright with Playwright-Go. Maybe that the browser can use selenium webdriver and if that is not available, then fall back playwright and then fall back to webextension. |
I'm actually most interested in Chrome's |
The biggest hurdle is using a standardised RDP. This; https://remotedebug.org/ isn't yet supported by all browsers!
The text was updated successfully, but these errors were encountered: