Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up SETUP guides #495

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Conversation

ananthb
Copy link
Contributor

@ananthb ananthb commented Dec 9, 2023

No description provided.

@ananthb
Copy link
Contributor Author

ananthb commented Dec 9, 2023

I haven't tested out these guides yet. I should be able to try all three out sometime next week.

@tombh tombh merged commit f9c6fcf into browsh-org:master Dec 9, 2023
3 checks passed
@tombh
Copy link
Member

tombh commented Dec 10, 2023

Thank you again!

Just a brief note about the Linux doc, I actually think it'd be better to delete all the custom deletion instructions. I don't think it should be our responsibility to describe how to install these very common tools on the minority of distributions that don't have them in their package managers.

@ananthb ananthb deleted the rework-setup-guides branch December 10, 2023 09:38
@ananthb
Copy link
Contributor Author

ananthb commented Dec 10, 2023

Makes sense. I've got a new PR with those changes.

tombh added a commit that referenced this pull request Jan 29, 2024
* Bump fast-json-patch and web-ext in /webext by @dependabot in #461
* Bump loader-utils from 2.0.2 to 2.0.4 in /webext by @dependabot in #453
* remove unnecessary RUN command by @lpmi-13 in #466
* Bump http-cache-semantics from 4.1.0 to 4.1.1 in /webext by @dependabot in #467
* fix: Golang install: use "amd64" for "x86_64" by @tombh in #463
* feat: Use log/slog for logging to file or stdout by @ananthb in #493
* feat: Structured log messages by @ananthb in #494
* chore: Clean up SETUP guides by @ananthb in #495
* chore: Remove manual install steps by @ananthb in #496
* fix: If debug is false discard logs by @ananthb in #497
* [Fix] Firefox inspecting logic on Windows by @Dragon1573 in #502
* feat: Add json schema (#505) by @Freed-Wu in #510

* @lpmi-13 made their first contribution in #466
* @ananthb made their first contribution in #493
* @Dragon1573 made their first contribution in #502
* @Freed-Wu made their first contribution in #510
@tombh tombh mentioned this pull request Jan 29, 2024
tombh added a commit that referenced this pull request Jan 29, 2024
* Bump fast-json-patch and web-ext in /webext by @dependabot in #461
* Bump loader-utils from 2.0.2 to 2.0.4 in /webext by @dependabot in #453
* remove unnecessary RUN command by @lpmi-13 in #466
* Bump http-cache-semantics from 4.1.0 to 4.1.1 in /webext by @dependabot in #467
* fix: Golang install: use "amd64" for "x86_64" by @tombh in #463
* feat: Use log/slog for logging to file or stdout by @ananthb in #493
* feat: Structured log messages by @ananthb in #494
* chore: Clean up SETUP guides by @ananthb in #495
* chore: Remove manual install steps by @ananthb in #496
* fix: If debug is false discard logs by @ananthb in #497
* [Fix] Firefox inspecting logic on Windows by @Dragon1573 in #502
* feat: Add json schema (#505) by @Freed-Wu in #510

* @lpmi-13 made their first contribution in #466
* @ananthb made their first contribution in #493
* @Dragon1573 made their first contribution in #502
* @Freed-Wu made their first contribution in #510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants