Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Firefox inspecting logic on Windows #502

Merged
merged 4 commits into from
Dec 24, 2023
Merged

[Fix] Firefox inspecting logic on Windows #502

merged 4 commits into from
Dec 24, 2023

Conversation

Dragon1573
Copy link
Contributor

This pull request makes following changes:

  1. It seems developers should use defer keyword to release some resources. There's a missing defer action in getFirefoxPath() function.
  2. For latest stable release of Mozilla Firefox, the registry path of key PathToExe is incorrect. It should be \HKEY_LOCAL_MACHINE\Software\Mozilla\Mozilla Firefox\120.0.1 (x64 zh-CN)\Main in my case.
  3. For all version of Mozilla Firefox, the registry key name is incorrect for getting version information. It should be CurrentVersion instead of an empty string.

It seems `defer` keyword is using to release and close some resources.
It should be added to `getFirefoxPath` function.

Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
For Mozilla Firefox Stable edition, it's incorrect in `getFirefoxPath` function.

Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
@tombh
Copy link
Member

tombh commented Dec 24, 2023

Thanks for this. I think we can merge this. Can you just fix the formatting lint warning?

@Dragon1573
Copy link
Contributor Author

I'm new to Golang, I just try to fix the bug as regarding it as a pseudo-code. Code format of this repository is graceful so it's easy to understand. 👍🏼

"Allow edits by maintainers" function is enabled. Is it possible for moderators or other contributors to commit fixes on my branch? Or is there any manual so I can try to fix the formatting lint warning on GitHub Codespace?

Advices from GitHub Workflows, try fix this using GitHub Web.
@tombh tombh merged commit 8bca0f1 into browsh-org:master Dec 24, 2023
3 checks passed
@tombh
Copy link
Member

tombh commented Dec 24, 2023

Thank you! I will make a release soon.

@Dragon1573 Dragon1573 deleted the issues/501 branch December 24, 2023 14:15
tombh added a commit that referenced this pull request Jan 29, 2024
* Bump fast-json-patch and web-ext in /webext by @dependabot in #461
* Bump loader-utils from 2.0.2 to 2.0.4 in /webext by @dependabot in #453
* remove unnecessary RUN command by @lpmi-13 in #466
* Bump http-cache-semantics from 4.1.0 to 4.1.1 in /webext by @dependabot in #467
* fix: Golang install: use "amd64" for "x86_64" by @tombh in #463
* feat: Use log/slog for logging to file or stdout by @ananthb in #493
* feat: Structured log messages by @ananthb in #494
* chore: Clean up SETUP guides by @ananthb in #495
* chore: Remove manual install steps by @ananthb in #496
* fix: If debug is false discard logs by @ananthb in #497
* [Fix] Firefox inspecting logic on Windows by @Dragon1573 in #502
* feat: Add json schema (#505) by @Freed-Wu in #510

* @lpmi-13 made their first contribution in #466
* @ananthb made their first contribution in #493
* @Dragon1573 made their first contribution in #502
* @Freed-Wu made their first contribution in #510
@tombh tombh mentioned this pull request Jan 29, 2024
tombh added a commit that referenced this pull request Jan 29, 2024
* Bump fast-json-patch and web-ext in /webext by @dependabot in #461
* Bump loader-utils from 2.0.2 to 2.0.4 in /webext by @dependabot in #453
* remove unnecessary RUN command by @lpmi-13 in #466
* Bump http-cache-semantics from 4.1.0 to 4.1.1 in /webext by @dependabot in #467
* fix: Golang install: use "amd64" for "x86_64" by @tombh in #463
* feat: Use log/slog for logging to file or stdout by @ananthb in #493
* feat: Structured log messages by @ananthb in #494
* chore: Clean up SETUP guides by @ananthb in #495
* chore: Remove manual install steps by @ananthb in #496
* fix: If debug is false discard logs by @ananthb in #497
* [Fix] Firefox inspecting logic on Windows by @Dragon1573 in #502
* feat: Add json schema (#505) by @Freed-Wu in #510

* @lpmi-13 made their first contribution in #466
* @ananthb made their first contribution in #493
* @Dragon1573 made their first contribution in #502
* @Freed-Wu made their first contribution in #510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants