-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Firefox inspecting logic on Windows #502
Conversation
It seems `defer` keyword is using to release and close some resources. It should be added to `getFirefoxPath` function. Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
For Mozilla Firefox Stable edition, it's incorrect in `getFirefoxPath` function. Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
Signed-off-by: Dragon1573 <49941141+Dragon1573@users.noreply.github.com>
Thanks for this. I think we can merge this. Can you just fix the formatting lint warning? |
I'm new to Golang, I just try to fix the bug as regarding it as a pseudo-code. Code format of this repository is graceful so it's easy to understand. 👍🏼 "Allow edits by maintainers" function is enabled. Is it possible for moderators or other contributors to commit fixes on my branch? Or is there any manual so I can try to fix the formatting lint warning on GitHub Codespace? |
Advices from GitHub Workflows, try fix this using GitHub Web.
Thank you! I will make a release soon. |
* Bump fast-json-patch and web-ext in /webext by @dependabot in #461 * Bump loader-utils from 2.0.2 to 2.0.4 in /webext by @dependabot in #453 * remove unnecessary RUN command by @lpmi-13 in #466 * Bump http-cache-semantics from 4.1.0 to 4.1.1 in /webext by @dependabot in #467 * fix: Golang install: use "amd64" for "x86_64" by @tombh in #463 * feat: Use log/slog for logging to file or stdout by @ananthb in #493 * feat: Structured log messages by @ananthb in #494 * chore: Clean up SETUP guides by @ananthb in #495 * chore: Remove manual install steps by @ananthb in #496 * fix: If debug is false discard logs by @ananthb in #497 * [Fix] Firefox inspecting logic on Windows by @Dragon1573 in #502 * feat: Add json schema (#505) by @Freed-Wu in #510 * @lpmi-13 made their first contribution in #466 * @ananthb made their first contribution in #493 * @Dragon1573 made their first contribution in #502 * @Freed-Wu made their first contribution in #510
* Bump fast-json-patch and web-ext in /webext by @dependabot in #461 * Bump loader-utils from 2.0.2 to 2.0.4 in /webext by @dependabot in #453 * remove unnecessary RUN command by @lpmi-13 in #466 * Bump http-cache-semantics from 4.1.0 to 4.1.1 in /webext by @dependabot in #467 * fix: Golang install: use "amd64" for "x86_64" by @tombh in #463 * feat: Use log/slog for logging to file or stdout by @ananthb in #493 * feat: Structured log messages by @ananthb in #494 * chore: Clean up SETUP guides by @ananthb in #495 * chore: Remove manual install steps by @ananthb in #496 * fix: If debug is false discard logs by @ananthb in #497 * [Fix] Firefox inspecting logic on Windows by @Dragon1573 in #502 * feat: Add json schema (#505) by @Freed-Wu in #510 * @lpmi-13 made their first contribution in #466 * @ananthb made their first contribution in #493 * @Dragon1573 made their first contribution in #502 * @Freed-Wu made their first contribution in #510
This pull request makes following changes:
defer
keyword to release some resources. There's a missingdefer
action ingetFirefoxPath()
function.PathToExe
is incorrect. It should be\HKEY_LOCAL_MACHINE\Software\Mozilla\Mozilla Firefox\120.0.1 (x64 zh-CN)\Main
in my case.CurrentVersion
instead of an empty string.