Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utf8 when writing to stdout in latexml #920

Merged
merged 2 commits into from Jan 7, 2018

Conversation

@dginev
Copy link
Collaborator

dginev commented Jan 6, 2018

Fixes #918

No rocket science here. Maybe before merging I should go through all executables in bin/ and ensure all default prints are using the utf8 encoding? cc @brucemiller

@dginev dginev assigned brucemiller and unassigned brucemiller Jan 6, 2018
@dginev dginev requested a review from brucemiller Jan 6, 2018
@dginev

This comment has been minimized.

Copy link
Collaborator Author

dginev commented Jan 7, 2018

Indeed, this issue could be seen also in latexmlpost and latexmlmath, which I hope got patched via my last commit. latexmlc was already enhanced, and also has an extra guard to not encode if the desired output is an archive file - so you can pipe through the ZIP content correctly.

Should be good to merge

@brucemiller

This comment has been minimized.

Copy link
Owner

brucemiller commented Jan 7, 2018

Yep, this looks to be exactly what's needed; I only wonder why it wasn't there already. Sloppiness, I guess ;>

@brucemiller brucemiller merged commit 3064b94 into brucemiller:master Jan 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.