Use utf8 when writing to stdout in latexml#920
Merged
Conversation
Collaborator
Author
|
Indeed, this issue could be seen also in latexmlpost and latexmlmath, which I hope got patched via my last commit. latexmlc was already enhanced, and also has an extra guard to not encode if the desired output is an archive file - so you can pipe through the ZIP content correctly. Should be good to merge |
Owner
|
Yep, this looks to be exactly what's needed; I only wonder why it wasn't there already. Sloppiness, I guess ;> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #918
No rocket science here. Maybe before merging I should go through all executables in
bin/and ensure all default prints are using the utf8 encoding? cc @brucemiller