New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iframe load/unload needs to work correctly #7

Closed

GoogleCodeExporter opened this issue Apr 1, 2015 · 1 comment

Labels

auto-migrated Priority-Medium Type-Defect

GoogleCodeExporter commented Apr 1, 2015

Moving back slides (left) doesn't unload them properly.

We always do:
window.setTimeout(this.disableSlideFrames_.bind(this, curSlide - 2), 301);

  this.enableSlideFrames_(curSlide - 1);
  this.enableSlideFrames_(curSlide + 1);
  this.enableSlideFrames_(curSlide + 2);

The first line won't work correctly if you're moving left.

Original issue reported on code.google.com by ebi...@gmail.com on 10 Apr 2012 at 10:23

The text was updated successfully, but these errors were encountered:

Author

GoogleCodeExporter commented Apr 1, 2015

We're no longer disabling/unloading iframes, but the loading works correctly.
It loads the next slide's iframe after a small amount of time to prevent jank
from the css transtions.

Original comment by ebi...@gmail.com on 22 Apr 2012 at 6:30

Changed state: Fixed
Added labels: ****
Removed labels: ****

GoogleCodeExporter added Priority-Medium Type-Defect auto-migrated labels

GoogleCodeExporter closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment