Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release/tag and dependencies version #15

Closed
Warvito opened this issue Oct 21, 2021 · 5 comments · Fixed by #16
Closed

Add release/tag and dependencies version #15

Warvito opened this issue Oct 21, 2021 · 5 comments · Fixed by #16

Comments

@Warvito
Copy link

Warvito commented Oct 21, 2021

Hi Mikael,

Congratulation on the great repository! I just wanted to make some suggestions; please, consider using Github tags or releases. It would make it easier to follow the latest updates/fixes of the tool. Also, it would be great to have specified the nitorch version that the unires uses to avoid having recent nitorch updates break any function from unires. Finally, it would be great to see the unires available at pypi to be easier to install and define it in the requirements. I would be more than happy to help with any of these suggestions; just let me know what you think. Cheers

@brudfors
Copy link
Owner

Hi Walter,

Nice to hear from you :) All great points, and something that, I agree, should be added to UniRes. The starting point I guess would be to make NITorch available in pypi. I will begin looking into this asap and possibly ask your assistance - thank you for offering!

@balbasty
Copy link
Collaborator

Hi Mikael,

You could start by explicitly listing nitorch as a (github) dependency in your setup.py and pin it to a specific commit that you know works well with UniRes. Some pointers here: https://stackoverflow.com/questions/55146691
I would also add [all] at the end of the URL so that all optional dependencies to nitorch are installed (nibabel, etc).

Happy to help with this ;)

@brudfors
Copy link
Owner

brudfors commented Nov 19, 2021

Hi @Warvito

Sorry this took ages, but I just pushed a PR that should sort out the dependency issue:

#16

Could you maybe try this, when you have the time, and let me know if it works for you?

I will then merge it into main. Then I will create a release tag, as requested :)

@brudfors
Copy link
Owner

Also @Warvito, if you are happy to help me get UniRes onto pypi, that would be great!

@brudfors
Copy link
Owner

Hi @Warvito,

@balbasty managed to test the changes that I made to the setup.py and it all worked on the GPU. Therefore, I created a release tag:

https://github.com/brudfors/UniRes/releases/tag/v0.1

Hope it is helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants