Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: filenames and underscore seperators #67

Closed
Cybergate9 opened this issue Oct 22, 2022 · 2 comments
Closed

minor: filenames and underscore seperators #67

Cybergate9 opened this issue Oct 22, 2022 · 2 comments
Labels
feature request New feature or request

Comments

@Cybergate9
Copy link

It'd be handy if auto generated filenames could consistently be 'split' on underscores, this is mostly the case, except, e.g.
imagine "cat in an art deco setting. photo realistic by {artist}" --sampler-type k_dpm_2
creates something like:
000155_458176395_k_dpm_240_PS7.5_cat_in_an_art_deco_setting.photo_realistic_by_saturno_butto[generated].jpg

where the sampler type itself has underscores (in this case k_dpm_2, but will be same for k_lms|k_dpm_2|k_dpm_2_a|k_euler|k_euler_a|k_heun) and therefore creates more items in a 'split' (compared to plain plms, ddim etc)..

maybe take underscores out of sampler names all together.. or.. just strip them out before creating filename?

@brycedrennan
Copy link
Owner

Good idea. It shall be done.

@brycedrennan brycedrennan added the feature request New feature or request label Oct 22, 2022
@brycedrennan
Copy link
Owner

Included in just released 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants