Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file:// path check #6

Closed
BryceRussell opened this issue Feb 15, 2024 · 1 comment
Closed

Fix file:// path check #6

BryceRussell opened this issue Feb 15, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@BryceRussell
Copy link
Owner

Currently, if a file:// path gets passed the package assumes that the path is a file and turns it into a directory, but file:// paths can be directories too. This function should check whether or not the file:// path is a file before using dirname() on it to get the directory

https://github.com/BryceRussell/astro-pages/blob/main/package/utils/add-page-dir.ts#L22
@BryceRussell BryceRussell added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 15, 2024
@BryceRussell
Copy link
Owner Author

Fixed in v0.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BryceRussell