Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minimum supported rust version #104

Closed
jorickert opened this issue Oct 14, 2019 · 2 comments · Fixed by #105
Closed

Document minimum supported rust version #104

jorickert opened this issue Oct 14, 2019 · 2 comments · Fixed by #105

Comments

@jorickert
Copy link
Contributor

It could be useful to specify a minimum required rust version and add an CI test to enforce this.
Note: zeroize 1.0 requires rustc 1.36 or newer

@brycx
Copy link
Member

brycx commented Oct 15, 2019

I agree this would be nice to have, instead of only supporting the latest stable Rust version. It would help users check whether it's possible for them to use orion on their platform.

This will however mean that future updates that bump MSRV will be breaking. This is currently not strictly the case, because orion only supports latest Rust stable. I won't hesitate to bump MSRV at any point though, if it improves the library. So pinning a MSRV will serve purely as an informational/documentation improvement.

Note: zeroize 1.0 requires rustc 1.36 or newer

Yup, I'm pretty sure MSRV would be 1.36 at this point.

@brycx
Copy link
Member

brycx commented Oct 19, 2019

I've seen multiple crates, including zeroize, stating that a bump in MSRV is not considered a breaking change on their part. It's not a part of the API evolution RFC either, so we can take the same approach to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants